saving two files using foreach

[Yuxi Chen]

Dear statalist,

I tried to load two files, make some changes, and save them in one go. However I just could not get it right.
Appreciated it in advance if anyone could point me the correct way.

global ylist "insurance mutual pension"

foreach file of local "emerging" "advanced" {
    import delimited `file'.csv, varnames(1) case(upper) clear 
    encode COUNTRYNAME, gen(COUNTRY)
    drop COUNTRYNAME
    rename *, lower
    foreach var of global $ylist {
        rename `var' `var'_`file'
    }
    xtset country year
    save `file', replace
}

[Clyde Schechter]

foreach file of local "emerging" "advanced"

is not valid Stata syntax. You must first create, and name, a local macro that contains "emerging" and "advanced" and then refer to that by its name in the -foreach- command. So:

local filenames emerging advanced
foreach file of local filelist {
    import delimited `file'.csv, varnames(1) case(upper) clear
    encode COUNTRYNAME, gen(COUNTRY)
    drop COUNTRYNAME
    rename *, lower
    foreach var of global $ylist {
        rename `var' `var'_`file'
    }
    xtset country year
    save `file', replace
}

As an aside, the use of global macros (I'm referring to ylist) is an unsafe programming practice that should only be used when no suitable alternative is available. There is no reason why this same information cannot be stored as a local macro.

[Yuxi Chen]

Thank you Clyder, it works now. appreciated your suggestion on global/local macros too

[Nick Cox]

Clyde Schechter meant

 local filelist emerging advanced

foreach file of local filelist {

while

foreach file in emerging advanced {

should work too