Using forvalues double loop gives "invalid name" r198

[Titir Bhattacharya]

Hi all, I'm trying to run a loop using forvalues as in the following:

forvalues `i'=0/1{
forvalues `j'=0/9{
capture noisily use "$temp\4_20`i'`j'_revised.dta"
capture noisily replace mandal_name="Am" if mandal_name=="Am Muncipality"
capture noisily replace mandal_name="An" if mandal_name=="An Muncipality"
capture noisily replace mandal_name="El" if mandal_name=="El Municipality"
capture noisily replace mandal_name="Sr" if mandal_name=="Sr Muncipality"
capture noisily replace mandal_name="De" if mandal_name=="Dev"

save "$temp\4_20`i'`j'_revised.dta",replace

clear

}
}
.

I define the

$temp

global before running the loop.

I get the following error

_= invalid name
r(198);

I'm not sure where the syntax has gone wrong. The file names are exactly as indicated in the loop: the actual file names are "4_2007_revised", "4_2018_revised" etc.

Would appreciate any help in this regard.

Thanks

[Joseph Coveney]

The typical syntax for forvalues is

forvalues i = 0/1 {
    forvalues j = 0/9 {

and not

forvalues `i'=0/1{
forvalues `j'=0/9{

[Nick Cox]

To cycle over 2000/2019, it is easier to go

forval y = 2000/2019 { 
        
     capture noisily use "$temp\4_`y'_revised.dta"      

} 

[Titir Bhattacharya]

The typical syntax for forvalues is

forvalues i = 0/1 {
forvalues j = 0/9 {

and not

forvalues `i'=0/1{
forvalues `j'=0/9{

Thanks Joseph!

[Titir Bhattacharya]

To cycle over 2000/2019, it is easier to go

forval y = 2000/2019 {

 capture noisily use "$temp\4_`y'_revised.dta" 

} 

Thanks Nick for the advice