Generate variables created out of two foreach commands

[Joshua Tievoor]

Good day all,

I have 8 existing variables A, B, C, D, E, F, G, H.

For each variable I want to create a new variable for each year between 2000 and 2010, and name it as a combination of the variable name and year. For example A2000 A2001 A2002 etc.

The below code seems to fail.

Does anyone know what I'm doing wrong?

foreach varname in A B C D E F G H{
    foreach num of numlist 2000(1)2010{
            gen `varname'+`num'=`varname' if year=`num'
    }
}

[Clyde Schechter]

Two things. The + between `varname' and `num' is a syntax error. And you need a double equals sign between year and `num' Thus

foreach varname in A B C D E F G H {
    foreach num of numlist 2000(1)2010 {
        gen `varname'`num' = `varname' if year == `num'
    }
}

[Joshua Tievoor]

Thanks! It's passed 1am here. I'm not at my sharpest for the day.

[Nick Cox]

Note that separate will do the inner loop task without a loop.

[Joshua Tievoor]

Thanks! I managed